fix(ffi): annotate body in raw body branch #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a simple test to verify if it work and make sure this issue will not happen in the future? Something like this: |
rholshausen
approved these changes
Aug 30, 2024
If the content type was not otherwise handled, `OptionalBody::from(&str)` was used. This sets the content type associated with the body to `None` irrespective of the content type passed through to `process_body`. This fixes the issue by ensuring the `OptionalBody::Present` is created with the appropriate content type. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
fix/body-content-type-annotation
branch
from
0097515
to
59c9ff3
Compare
tienvx
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the content type was not otherwise handled,
OptionalBody::from(&str)was used. This sets the content type associated with the body toNoneirrespective of the content type passed through toprocess_body.This fixes the issue by ensuring the
OptionalBody::Presentis created with the appropriate content type.