Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate --consumer-app-version from git commit when --auto-detect-version-properties is used. #100

Closed
bethesque opened this issue Nov 19, 2021 · 3 comments · Fixed by #119
Closed

Populate --consumer-app-version from git commit when --auto-detect-version-properties is used. #100

bethesque opened this issue Nov 19, 2021 · 3 comments · Fixed by #119

Comments

@bethesque
Copy link
Member

Currently, you must provide the -consumer-app-version as well as --auto-detect-version-properties
@TimothyJones
Copy link
Contributor

This is a good idea! I think --consumer-app-version should override anything that was autodetected, though.

This was referenced Sep 30, 2022
Merged
Merged
@YOU54F YOU54F mentioned this issue Oct 27, 2022
Merged
@github-actions
Copy link

👋 Thanks, this ticket has been added to the PactFlow team's backlog as PACT-611

@TimothyJones
Copy link
Contributor

^ Can we get this public? It's not a great experience as an outside interested party to see issues moved somewhere that we can't see them.

@YOU54F YOU54F mentioned this issue Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Auto detect commit sha, add shorthand -r flag pact-foundation/pact_broker-client
3 participants
@mefellows @bethesque @TimothyJones