Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer overrun in printable_binnary #33

Closed
guillerodriguez opened this issue Feb 21, 2017 · 0 comments · Fixed by #34
Closed

Buffer overrun in printable_binnary #33

guillerodriguez opened this issue Feb 21, 2017 · 0 comments · Fixed by #34

Comments

@guillerodriguez
Copy link
Contributor

There is a buffer overrun in the printable_binnary function in pkutils.c. It can be triggered with the following test case:

char data[48];
int i;
data[0] = 'a';
for (i = 1; i < 48; i++)
  data[i] = -1;

pk_log_raw_data(PK_LOG_ALL, "app", data, 48);

This is probably the issue that causes #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant