Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rarity for Collection Log and Loot #139

Open
zeroquinc opened this issue Jan 21, 2023 · 6 comments
Open

Drop Rarity for Collection Log and Loot #139

zeroquinc opened this issue Jan 21, 2023 · 6 comments

Comments

@zeroquinc
Copy link

zeroquinc commented Jan 21, 2023

It would be a nice touch to see the drop rarity for the Collection Log and Loot tabs. Maybe also for Pets and Clues?

Something like this I have in mind:

GLQHA4o

Now it only shows you the GE value.

Maybe also a toggle to set Min Drop Rarity to filter out some loot drops that wouldn't get passed if under the Min Loot Value threshold.

Thoughts?

@pajlada
Copy link
Member

pajlada commented Jan 21, 2023

We don't know which pet the user has received as the messaging is only "something has snuck into your pocket", so that wouldn't be possible.

Right now, drop rarity is not something we have accessible to us. I imagine this would need to be data we fetch from the wiki on a per-item basis.
Since items can be received from multiple sources, we need to do a lookup on the combination of the item & where it came from.
As an example of one of these, the Kraken tentacle is 1/400 from the Kraken, but 1/1,200 from a Cave kraken.

If we can add the ability to map an item + source to a drop rarity, this would be something we can add to some Loot notifications, most Clue Scrolls, & most of the Collection Log items.

@Felanbird
Copy link
Member

The problem I have personally with drop rates is how do we actually know it's the correct one? Unless the game secretly tells the client what drop it actually is, I see a problem with drop rates.

For example, reward casket (medium) has purple sweets listed as dropping in bunches of 5-10 & 8-12, which means pool one can be 5, 6, 7, 8, 9, 10 sweets, and pool two is 8, 9, 10, 11, 12

So how are we supposed to know what notif to fire for 8, 9, and 10 sweets, as it's a possibility from both pools. 🤔

@pajlada
Copy link
Member

pajlada commented Jan 21, 2023

So how are we supposed to know what notif to fire for 8, 9, and 10 sweets, as it's a possibility from both pools. thinking

If an item has multiple rarities, we could just omit that information. I imagine that won't be the case for very many items since it can only apply to stackable items

@zeroquinc
Copy link
Author

I didn't know it worked like that. I thought it already mapped the right NPC / activity. I don't really know how the other plugin does it? Maybe you could get some inspiration out of that code.

@pajlada
Copy link
Member

pajlada commented Jan 21, 2023

Which plugin is this @zeroquinc ?

@zeroquinc
Copy link
Author

Which plugin is this @zeroquinc ?

https://github.com/BossHuso/discord-rare-drop-notificater

@iProdigy iProdigy added the blocked Something out of our power needs to change before proceeding with this issue label Mar 3, 2023
@iProdigy iProdigy removed the blocked Something out of our power needs to change before proceeding with this issue label Feb 16, 2024
@iProdigy iProdigy self-assigned this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants