Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncryptedFileSystem does not support recursive delete #117

Open
TheBeruriahIncident opened this issue Apr 19, 2018 · 5 comments
Open

EncryptedFileSystem does not support recursive delete #117

TheBeruriahIncident opened this issue Apr 19, 2018 · 5 comments

Comments

@TheBeruriahIncident
Copy link

https://github.com/palantir/hadoop-crypto/blob/develop/hadoop-crypto/src/main/java/com/palantir/crypto2/hadoop/EncryptedFileSystem.java#L147

I may be missing some complexity, but it seems like recursive delete would just be a few more lines. Is there something I'm missing that would make this more complicated? Would a PR to support this be accepted?

@TheBeruriahIncident
Copy link
Author

Just realized (it's not in the README but) there's a StandaloneEncryptedFileSystem that already supports recursive delete. I don't really see why to use one or the other, other than that StandaloneEncryptedFileSystem has a kind of weird requirement to insert an e at the start of the uris that it then removes.

@ellisjoe
Copy link
Contributor

ellisjoe commented May 9, 2018

We need to make KeyStorageStrategy expose recursive delete and rename options in order for EncryptedFileSystem to support recursive delete and move. This is unlikely to happen any time soon, so the recommendation in the short term is either use StandaloneEncryptedFileSystem or use the EncryptedFileSystem with the FileKeyStorageStrategy and recursively delete or move on the underlying filesystem.

@rahij
Copy link

rahij commented Apr 25, 2019

@ellisjoe is it still true that exposing recursive delete and rename options in KeyStorageStrategy won't happen anytime soon?

@ellisjoe
Copy link
Contributor

@rahij we should talk about your need for recursive delete. Hasn't been a priority thus far.

@rahij
Copy link

rahij commented Apr 29, 2019

Synced offline with Joe, we have a workaround for the internal library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants