Remove label-undefined rule (#1614)

Resolves #877. This rule is already covered by compiler checks.
palantir · Oct 9, 2016 · cbe88c3 · cbe88c3
1 parent 8375782
commit cbe88c3
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 165 deletions.
diff --git a/docs/_data/rules.json b/docs/_data/rules.json
@@ -208,18 +208,6 @@
     ],
     "type": "functionality"
   },
-  {
-    "ruleName": "label-undefined",
-    "description": "Checks that labels are defined before usage.",
-    "descriptionDetails": "This rule is now implemented in the TypeScript compiler and does not need to be used.",
-    "rationale": "Using `break` or `continue` to go to an out-of-scope label is an error in JS.",
-    "optionsDescription": "Not configurable.",
-    "options": null,
-    "optionExamples": [
-      "true"
-    ],
-    "type": "functionality"
-  },
   {
     "ruleName": "linebreak-style",
     "description": "Enforces a consistent linebreak style.",
@@ -1312,4 +1300,4 @@
     ],
     "type": "style"
   }
-]
+]
diff --git a/docs/rules/label-undefined/index.html b/docs/rules/label-undefined/index.html
diff --git a/src/configs/recommended.ts b/src/configs/recommended.ts
@@ -32,7 +32,6 @@ export const rules = {
     "interface-name": [true, "always-prefix"],
     "jsdoc-format": true,
     "label-position": true,
-    "label-undefined": true,
     "max-line-length": [true, 120],
     "member-access": true,
     "member-ordering": [true,

diff --git a/src/rules/labelUndefinedRule.ts b/src/rules/labelUndefinedRule.ts
diff --git a/src/tsconfig.json b/src/tsconfig.json
@@ -90,7 +90,6 @@
         "rules/interfaceNameRule.ts",
         "rules/jsdocFormatRule.ts",
         "rules/labelPositionRule.ts",
-        "rules/labelUndefinedRule.ts",
         "rules/linebreakStyleRule.ts",
         "rules/maxFileLineCountRule.ts",
         "rules/maxLineLengthRule.ts",

diff --git a/test/rules/label-undefined/test.ts.lint b/test/rules/label-undefined/test.ts.lint
diff --git a/test/rules/label-undefined/tslint.json b/test/rules/label-undefined/tslint.json
diff --git a/test/tsconfig.json b/test/tsconfig.json
@@ -85,7 +85,6 @@
         "../src/rules/interfaceNameRule.ts",
         "../src/rules/jsdocFormatRule.ts",
         "../src/rules/labelPositionRule.ts",
-        "../src/rules/labelUndefinedRule.ts",
         "../src/rules/linebreakStyleRule.ts",
         "../src/rules/maxFileLineCountRule.ts",
         "../src/rules/maxLineLengthRule.ts",