This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rewrite semicolonRule #2240
Merged
Rewrite semicolonRule #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify ASI checks for TypeAlias, import, export and debugger Simplify checks for semicolon [bugfix] Ignore comments when checking for unnecessary semicolon [bugfix] Don't report unnecessary semicolon when followed by regex literal [enhancement] New check for export statements [enhancement] Report unnecessary semicolons in classes and in statement position (for option "always" too) Fix lint errors
[enhancement] check for semicolon after method overload [enhancement] check for semicolon in type literals. To restore the old behaviour use the new options `ignore-type-literals` [new-rule-option] `ignore-type-literals` added to `semicolon`
Will be added later in a followup PR
|
I reverted the changes regarding type literals for now, because they caused too much failures. |
|
please resolve conflict |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Simplify ASI checks for TypeAlias, import, export and debugger
Simplify checks for semicolon
[bugfix]
semicolonIgnore comments when checking for unnecessary semicolon[bugfix]
semicolonDon't report unnecessary semicolon when followed by regex literal[enhancement]
semicolonNew check for export statements, function overloads and shorthand module declaration[enhancement]
semicolonReport unnecessary semicolons in classes and in statement position (for option "always" too)[enhancement]
semicoloncheck for semicolon after method overloadIs there anything you'd like reviewers to focus on?
This is just the beginning to make option "never" fully ASI compatible.