Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add "ban-types" to tslint:latest. #2271

Merged
merged 4 commits into from Feb 28, 2017
Merged

Add "ban-types" to tslint:latest. #2271

merged 4 commits into from Feb 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2017

PR checklist

Overview of change:

Added a default setting for ban-types. This is the same as the forbidden-types rule used to do in types-publisher.

CHANGELOG.md entry:

[enhancement] Add "ban-types" to tslint:latest.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this addresses part of #2263

@adidahiya
Copy link
Contributor

Looks like there are some lint failures in the build @andy-ms

@nchen63
Copy link
Contributor

nchen63 commented Feb 28, 2017

are the changes to package.json needed?

@ghost
Copy link
Author

ghost commented Feb 28, 2017

I added a .d.ts file in a lint rule, which was being linted. Can't make it a .test.ts file, and that seems unnecessary if we can just ignore the entire directory.
EDIT: Looking at this more... actually I was getting confused because some files from #2273 were hanging around. (I had created a node_modules for the test imports, but looks like that isn't necessary.)

@nchen63
Copy link
Contributor

nchen63 commented Feb 28, 2017

@andy-ms thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants