Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Remove scanAllTokens and SkippableTokenAwareRuleWalker #2370

Merged
merged 2 commits into from
Mar 20, 2017

Conversation

andy-hanson
Copy link
Contributor

@andy-hanson andy-hanson commented Mar 18, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

[api] Removed deprecated scanAllTokens and skippableTokenAwareRuleWalker

@ajafff
Copy link
Contributor

ajafff commented Mar 18, 2017

You can probably also remove SkippableTokenAwareRuleWalker since they are always used together.

We are already breaking custom rule packages, so we can do the cleanup right.
I'll send a PR to tslint-eslint-rules to fix it after this PR landed. https://github.com/buzinas/tslint-eslint-rules/search?utf8=%E2%9C%93&q=scanAllTokens+skippabletokenawarerulewalker&type=Code

@andy-hanson andy-hanson changed the title Remove deprecated function "scanAllTokens" Remove scanAllTokens and SkippableTokenAwareRuleWalker Mar 18, 2017
}
}

class NoImportSideEffectWalker extends Lint.SkippableTokenAwareRuleWalker {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This never even used the scanner.

Copy link
Contributor

@nchen63 nchen63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@nchen63 nchen63 merged commit 12d5b95 into palantir:master Mar 20, 2017
@andy-hanson andy-hanson deleted the rm_scanalltokens branch March 20, 2017 02:11
AJamesPhillips pushed a commit to AJamesPhillips/tslint that referenced this pull request Mar 23, 2017
* Remove deprecated function "scanAllTokens"

* Remove SkippableTokenAwareRuleWalker too
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants