Removed annoying formatting rules from recommended ruleset #4871
Conversation
JoshuaKGoldberg
added
PR: waiting for author
PR: waiting for reviewer
and removed
PR: waiting for author
labels
|
When will this be released? :) |
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this change, we bring back these rules in the CLI.
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules. Until version 10, this is an opt-in migration and users will need to run this manually with the below command: ``` ng update @angular/cli --migrate-only tslint-version-6 ``` Closes: #17117 Reference: TOOL-1348
|
😢 @JoshuaKGoldberg why these changes? it removes a lot of very appreciable rules in the so-called "recommended" rule set |
|
Great .. i was wondering why code suddenly did not have enforced rules. Trailingsemicolon and commans are for better git changelogs. We relied on the recommended to better document what we wanted to tweak... this was probably a wrong decision ... No wi need to clean up a lot of mess cause devs of course upgraded tslint package and got less strict new defaults. |
|
For pure styling I would recommend prettier. This will also autofix your code :) |
|
For good reason were not. Those checks are not for styling but good reason as clean git history. I would approve some of the removals which are highly opinionated. But commans and curly braces as well as semicolons have more meaning and often clutter diffs. |
|
This change to the recommended rule set had been planned for a very long time. TSLint is deprecated and we won't be making any more significant changes to its API. |
PR checklist
[ ] Includes tests[ ] Documentation updateOverview of change:
Removes a bunch of rules from
recommended.tsaround formatting and whitespace. Also addsallow-leading-underscoretovariable-name.CHANGELOG.md entry:
[rule-change] Removed formatting and whitespace rules from recommended ruleset