From 8ee831cdbd8ace0cee904b915883b1ac08647fee Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Sun, 29 Oct 2017 20:20:12 +0100 Subject: [PATCH 1/3] no-redundant-jsdoc: handle class tag Fixes: #3413 --- src/rules/noRedundantJsdocRule.ts | 3 ++- test/rules/no-redundant-jsdoc/test.ts.lint | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/rules/noRedundantJsdocRule.ts b/src/rules/noRedundantJsdocRule.ts index f80f1ce4494..f329afc53b7 100644 --- a/src/rules/noRedundantJsdocRule.ts +++ b/src/rules/noRedundantJsdocRule.ts @@ -75,6 +75,8 @@ function walk(ctx: Lint.WalkContext): void { // OK break; + case ts.SyntaxKind.JSDocClassTag: + case ts.SyntaxKind.JSDocTypeLiteral: case ts.SyntaxKind.JSDocTemplateTag: case ts.SyntaxKind.JSDocTypeTag: case ts.SyntaxKind.JSDocTypedefTag: @@ -105,7 +107,6 @@ function walk(ctx: Lint.WalkContext): void { const redundantTags = new Set([ "abstract", "access", - "class", "constant", "constructs", "default", diff --git a/test/rules/no-redundant-jsdoc/test.ts.lint b/test/rules/no-redundant-jsdoc/test.ts.lint index c5669b39332..f386a149240 100644 --- a/test/rules/no-redundant-jsdoc/test.ts.lint +++ b/test/rules/no-redundant-jsdoc/test.ts.lint @@ -10,6 +10,8 @@ function f() {} const x = 0; /** + * @class + ~~~~~ [tag % ('class')] * @param {number} x Is a number ~~~~~~~~ [type] * @param y From 3da3f5a0d73661a3fd5233eca2778272bc2e4092 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Sun, 29 Oct 2017 20:25:16 +0100 Subject: [PATCH 2/3] add class back to set of redundant tags for older versions of typescript --- src/rules/noRedundantJsdocRule.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/noRedundantJsdocRule.ts b/src/rules/noRedundantJsdocRule.ts index f329afc53b7..99de98f0804 100644 --- a/src/rules/noRedundantJsdocRule.ts +++ b/src/rules/noRedundantJsdocRule.ts @@ -107,6 +107,7 @@ function walk(ctx: Lint.WalkContext): void { const redundantTags = new Set([ "abstract", "access", + "class", "constant", "constructs", "default", From ff25c9b51488e1db859766e1a1f808f86954b152 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Tue, 31 Oct 2017 00:32:37 +0100 Subject: [PATCH 3/3] remove JSDocTypeLiteral --- src/rules/noRedundantJsdocRule.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rules/noRedundantJsdocRule.ts b/src/rules/noRedundantJsdocRule.ts index 99de98f0804..9ecde8ef1e2 100644 --- a/src/rules/noRedundantJsdocRule.ts +++ b/src/rules/noRedundantJsdocRule.ts @@ -76,7 +76,6 @@ function walk(ctx: Lint.WalkContext): void { break; case ts.SyntaxKind.JSDocClassTag: - case ts.SyntaxKind.JSDocTypeLiteral: case ts.SyntaxKind.JSDocTemplateTag: case ts.SyntaxKind.JSDocTypeTag: case ts.SyntaxKind.JSDocTypedefTag: