Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async support #1031

Closed
racterub opened this issue Jan 12, 2022 · 2 comments
Closed

async support #1031

racterub opened this issue Jan 12, 2022 · 2 comments

Comments

@racterub
Copy link

racterub commented Jan 12, 2022

SQLAlchemy 1.4 includes async support. Can this be used from Flask-SQLAlchemy?

@davidism davidism changed the title [Feature request] Adding async support on flask-sqlalchemy async support Jan 12, 2022
@davidism
Copy link
Member

It is not a huge change to enable this, but it will probably not happen for quite some time. You can already override the engine and session method of the extension to return whatever you want, so it's already possible to get this. The extension itself doesn't need any async code, it only needs to return async engine and session objects.

@racterub
Copy link
Author

@davidism Thanks for the reply and yes I've already considered to manually overide the engine.
I just think it will be great to add this feature to flask-sqlalchemy, just my own thought :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants