Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default naming convention #1352

Open
yuxiaoy1 opened this issue Jun 26, 2024 · 4 comments
Open

Default naming convention #1352

yuxiaoy1 opened this issue Jun 26, 2024 · 4 comments

Comments

@yuxiaoy1
Copy link
Contributor

The naming convetion mentioned in docs is useful in some migration situations, would it be better to set it as default?
@davidism
Copy link
Member

It would break all existing databases that were created with the default. Fairly sure that’s why it wasn’t changed in SQLAlchemy either.

@davidism
Copy link
Member

I have thought about adding the suggested value as something that can be imported. Perhaps a subclass that uses that value if nothing is passed.

@yuxiaoy1
Copy link
Contributor Author

Maybe a new metadata object MetaDataWithNamingConvetion? then the db can be initialized as db = SQLAlchemy(metadata=MetaDataWithNamingConvetion)

@yuxiaoy1
Copy link
Contributor Author

Hello @davidism , do you have any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidism @yuxiaoy1