Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp singer get_timestamp implementation differs between 0.24 and 1.x #118

Closed
ergo opened this issue Oct 31, 2018 · 2 comments
Closed

Comments

@ergo
Copy link

ergo commented Oct 31, 2018

Hi,

It seems that services using itsdangerous 0.24 can't communicate with 1.1.0 and timestamp singer fails with too old timestamp error.

0.24 has:

def get_timestamp(self):
    """Returns the current timestamp.  This implementation returns the
    seconds since 1/1/2011.  The function must return an integer.
    """
    return int(time.time() - EPOCH)

But 1.1 has:

def get_timestamp(self):
    """Returns the current timestamp. The function must return an
    integer.
    """
    return int(time.time())

In its implementation.

@ThiefMaster
Copy link
Member

See #46 - this is intentional (and 1.0 was a major version bump so breaking changes are acceptable there)

@ergo
Copy link
Author

ergo commented Oct 31, 2018

@ThiefMaster then #111 change was acceptable too by same logic.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants