Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change in dependency markupsafe #1586

Closed
ankush opened this issue Feb 18, 2022 · 2 comments
Closed

breaking change in dependency markupsafe #1586

ankush opened this issue Feb 18, 2022 · 2 comments

Comments

@ankush
Copy link

ankush commented Feb 18, 2022

Jinja depends on markupsafe>=0.23

jinja/setup.py

Line 53 in cf21539

install_requires=["MarkupSafe>=0.23"],

Latest version of markupsafe removed soft_unicode and py3.6 support: https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-0

Which is used by filters.py

from markupsafe import soft_unicode

I am not sure about the best solution to this, maybe pin markupsafe <=2.0.1?

Environment:

  • Python version: 3.9
  • Jinja version: 2.11.x
@davidism
Copy link
Member

davidism commented Feb 18, 2022

Duplicate of #1585

You are using an unsupported version of the project, please update to the latest version. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

@ankush
Copy link
Author

ankush commented Feb 18, 2022

@davidism thanks, should've checked closed issues 🙈

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants