Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: clean up deprecation warning #24610

Closed
jreback opened this issue Jan 4, 2019 · 3 comments
Closed

TST: clean up deprecation warning #24610

jreback opened this issue Jan 4, 2019 · 3 comments
Labels
good first issue Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

I think these are only in 3.7, but have to be careful not to break other versions.

(pandas) bash-3.2$ pytest pandas/tests/dtypes/test_dtypes.py -k test_pickle
========================================================================================================================= test session starts ==========================================================================================================================
platform darwin -- Python 3.7.2, pytest-4.0.2, py-1.7.0, pluggy-0.8.0
hypothesis profile 'ci' -> timeout=-1, deadline=500, suppress_health_check=[HealthCheck.too_slow], database=DirectoryBasedExampleDatabase('/Users/jreback/pandas/.hypothesis/examples')
rootdir: /Users/jreback/pandas, inifile: setup.cfg
plugins: xdist-1.25.0, forked-0.2, cov-2.6.0, hypothesis-3.85.3
collected 244 items / 240 deselected                                                                                                                                                                                                                                   

pandas/tests/dtypes/test_dtypes.py ....                                                                                                                                                                                                                          [100%]

=========================================================================================================================== warnings summary ===========================================================================================================================
pandas/tests/dtypes/test_dtypes.py::TestCategoricalDtype::test_pickle
  /Users/jreback/miniconda3/envs/pandas/lib/python3.7/site-packages/botocore/vendored/requests/packages/urllib3/_collections.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    from collections import Mapping, MutableMapping
  /Users/jreback/miniconda3/envs/pandas/lib/python3.7/site-packages/botocore/vendored/requests/packages/urllib3/_collections.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    from collections import Mapping, MutableMapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
========================================================================================================= 4 passed, 240 deselected, 2 warnings in 0.25 seconds =========================================================================================================
@jreback jreback added Testing pandas testing functions or related to the test suite good first issue labels Jan 4, 2019
@jreback jreback added this to the Contributions Welcome milestone Jan 4, 2019
@TomAugspurger
Copy link
Contributor

Those are from boto. Nothing we can do about it, other than push on boto/botocore#1615

@TomAugspurger TomAugspurger modified the milestones: Contributions Welcome, No action Jan 4, 2019
@TomAugspurger
Copy link
Contributor

That said, I really don't know why certain tests trigger these... I wonder which piece of code is triggering a boto import in pickle IO.

@TomAugspurger
Copy link
Contributor

It's _get_handle in io/common.py, which imports s3fs, which imports boto. We could maybe avoid that with some effort...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants