Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving tests/ outside the pandas module #31327

Closed
joaoe opened this issue Jan 26, 2020 · 2 comments
Closed

Consider moving tests/ outside the pandas module #31327

joaoe opened this issue Jan 26, 2020 · 2 comments

Comments

@joaoe
Copy link

joaoe commented Jan 26, 2020

Problem description

Hi.
After a pip install pandas the lib/site-packages/pands/tests/ includes a lot of testing code which is definitely not relevant for me and many other end users of pandas.
This bloats the installation and makes installation slower.
I'm working on packaging a python environment to distribute with a preinstalled set of modules and application and there are too many popular 3rd-party modules which include unneeded test code, like numpy, IPython jupyterlab, etc, which needs to be striped to keep the package size down. I'll be reporting issues to these projects as well.

Suggestion

Therefore, my suggestion is to keep the pandas module streamlined, and move the tests out. Perhaps create a pandas-unittests module if people are interested in it, or just expect users to checkout the code. Another possibility would be to skip packaging the tests folder and conftest.py when creating packages to upload to pypi.org.

Since you are now almost releasing 1.0 it might be a bit short notice to include this is such a big release. But for the next major release, it could work.

Thank you very much for your attention.

@MarcoGorelli
Copy link
Member

Thanks for the suggestion - I think this is a duplicate of #30741 and so will close the issue for now, but please feel free to reopen if you disagree :)

@joaoe
Copy link
Author

joaoe commented Jan 26, 2020

That seems like it. Thanks. I did search but could not find that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants