Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Split/Trim github.event.comment.user.login on issue_assign job in comment_commands.yml #60358

Open
1 of 3 tasks
KevsterAmp opened this issue Nov 19, 2024 · 2 comments · May be fixed by #60359
Open
1 of 3 tasks

ENH: Split/Trim github.event.comment.user.login on issue_assign job in comment_commands.yml #60358

KevsterAmp opened this issue Nov 19, 2024 · 2 comments · May be fixed by #60359
Assignees
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@KevsterAmp
Copy link
Contributor

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

Comments containing "take" with leading spaces gets skipped by the issue_assign job. Got a couple of experiences with this because I usually click Enter by reflex after typing in a comment. So my comment becomestake\n, which gets skipped by this job

Feature Description

if: (!github.event.issue.pull_request) && github.event.comment.body == 'take'

Add trim() command inside github.event.comment.body

    if: (!github.event.issue.pull_request) && trim(github.event.comment.body) == 'take'

Alternative Solutions

NA; Enhancement is straight forward

Additional Context

No response

@KevsterAmp KevsterAmp added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 19, 2024
@KevsterAmp
Copy link
Contributor Author

take

@KevsterAmp
Copy link
Contributor Author

Here's an example of a "take\n" run that was skipped by the job: https://github.com/pandas-dev/pandas/actions/runs/11903615411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant