-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: make vbench runnable in python 3 #9660
Comments
I think we should also consider in looking into Airspeed velocity is actively developed and maintained, other projects like scipy did also start using it, and it has some nice extra features (eg memory benchmarking, interactive web frontend). So maybe it is more worth the effort looking into that, than trying to improve vbench. Apparently @qwhelan did already some work on this: airspeed-velocity/asv#194 |
I agree. I figured I would see how much work it would be to get vbench working in Python3 and then go from there. It was a few simple changes on the vbench side and definitely the harder part is going to be getting the benchmarks compatible. However, this would probably need to be done anyways for |
@jorisvandenbossche Definitely have some comments but I'll have to get back to you guys this weekend. They've added a lot of support for vbench features I thought were significant but I haven't had a chance in the last few weeks to see what's fully/partially/not at all supported. |
@jorisvandenbossche I have a short script that converts |
@qwhelan And what about some of the other things you noted: is it possible to keep the benchmarks in the pandas repo or does it have to be a separate repo? And are the similar abilities to our |
And BTW, thanks a lot for working on this! |
@jorisvandenbossche They've changed it so everything can be stored in the same repo. Also, the |
good to hear! Just open a PR with what you have, that is the easiest to try out/give feedback |
Closing as it is probably not worth to put more work in vbench if we are going to use asv (see #9715) |
I believe this is possible ATM.
The text was updated successfully, but these errors were encountered: