Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: make vbench runnable in python 3 #9660

Closed
jreback opened this issue Mar 15, 2015 · 9 comments · May be fixed by wesm/vbench#36
Closed

PERF: make vbench runnable in python 3 #9660

jreback opened this issue Mar 15, 2015 · 9 comments · May be fixed by wesm/vbench#36
Labels
Performance Memory or execution speed performance

Comments

@jreback
Copy link
Contributor

jreback commented Mar 15, 2015

I believe this is possible ATM.

@jreback jreback added Performance Memory or execution speed performance 2/3 Compat labels Mar 15, 2015
@jreback jreback added this to the Next Major Release milestone Mar 15, 2015
@jorisvandenbossche
Copy link
Member

I think we should also consider in looking into asv (airspeed velocity), if it would be possible to replace our current vbench suite to that (issue for that is: #8361).

Airspeed velocity is actively developed and maintained, other projects like scipy did also start using it, and it has some nice extra features (eg memory benchmarking, interactive web frontend). So maybe it is more worth the effort looking into that, than trying to improve vbench.

Apparently @qwhelan did already some work on this: airspeed-velocity/asv#194
@qwhelan, maybe you can share some thoughts about this?

@rockg
Copy link
Contributor

rockg commented Mar 20, 2015

I agree. I figured I would see how much work it would be to get vbench working in Python3 and then go from there. It was a few simple changes on the vbench side and definitely the harder part is going to be getting the benchmarks compatible. However, this would probably need to be done anyways for asv so I figured it was worth proceeding with vbench. The suite can be run in Python3 now with my vbench changes (note that I didn't do a full test of plotting, but nothing there seemed to stand out as an issue).

@qwhelan
Copy link
Contributor

qwhelan commented Mar 20, 2015

@jorisvandenbossche Definitely have some comments but I'll have to get back to you guys this weekend. They've added a lot of support for vbench features I thought were significant but I haven't had a chance in the last few weeks to see what's fully/partially/not at all supported.

@qwhelan
Copy link
Contributor

qwhelan commented Mar 23, 2015

@jorisvandenbossche I have a short script that converts vbench Benchmarks into asv ones with a little bit of ast use. There's a bit of information being lost (at least comments and start dates) but I don't see any issues that would prevent us from having things in parallel for a bit. I'm still working through some compilation issues that I'm fairly sure are OSX-specific, but I do have a subset of our vbench cases running under asv via my translation script. If I don't run into any issues, I'll upload a cleaned-up version tomorrow night.

@jorisvandenbossche
Copy link
Member

@qwhelan And what about some of the other things you noted: is it possible to keep the benchmarks in the pandas repo or does it have to be a separate repo? And are the similar abilities to our test_perf.sh script?

@jorisvandenbossche
Copy link
Member

And BTW, thanks a lot for working on this!

@qwhelan
Copy link
Contributor

qwhelan commented Mar 23, 2015

@jorisvandenbossche They've changed it so everything can be stored in the same repo. Also, the asv run and asv compare commands should be able to mostly replace test_perf.py, though there may be some specific commands missing. Notably, it doesn't have the daily sampling vbench does - it will just uniformly slice the commit range based on the number of commits.

@jorisvandenbossche
Copy link
Member

good to hear! Just open a PR with what you have, that is the easiest to try out/give feedback

@jorisvandenbossche
Copy link
Member

Closing as it is probably not worth to put more work in vbench if we are going to use asv (see #9715)

@jorisvandenbossche jorisvandenbossche modified the milestones: No action, 0.17.0 Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants