New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeRequest does not have listener for 'error' event #4

Open

aarsilv opened this issue Jan 27, 2014 · 0 comments

aarsilv commented Jan 27, 2014

Request errors are ignored, which makes it hard to debug and/or for applications to handle them. Ideally you pass request errors like other errors:

panda.js - makeRequest function:

    res.addListener('error', function(err) {
        cb({error: 'requestError', message: err.message});
    });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment