Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: add [go-test].timeout_default #13782

Closed
Tracked by #17447
Eric-Arellano opened this issue Dec 2, 2021 · 3 comments
Closed
Tracked by #17447

Go: add [go-test].timeout_default #13782

Eric-Arellano opened this issue Dec 2, 2021 · 3 comments
Labels
backend: Go Go backend-related issues enhancement

Comments

@Eric-Arellano
Copy link
Contributor

Follow up to #13707. Add these options:

  • [go-test].timeout_default, which you fall back to if the field is not set. Defaults to not being set, meaning no timeouts.
  • [go-test].timeout_maximum
  • [go-test].timeouts to toggle the feature entirely. Useful when debugging to disable timeouts

These have worked well for Python.

While at it, also add to Shell.

@Eric-Arellano Eric-Arellano added enhancement backend: Go Go backend-related issues labels Dec 2, 2021
@tdyas
Copy link
Contributor

tdyas commented Dec 14, 2022

@Eric-Arellano: Should the Go timeout respect the global [test].timeout_default and [test].timeout_maximum options instead?

@Eric-Arellano
Copy link
Contributor Author

Ah yeah, this ticket is stale from before that improvement. Good catch

@tdyas
Copy link
Contributor

tdyas commented Dec 14, 2022

Looks like this already done due to TestTimeoutField.

@tdyas tdyas closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues enhancement
Projects
None yet
Development

No branches or pull requests

2 participants