Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antlr3 generated target has unstable hash and uncache-able due to timestamp in generated code #1668

Closed
qma opened this issue Jun 11, 2015 · 3 comments

Comments

@qma
Copy link
Contributor

qma commented Jun 11, 2015

antlr3 puts a comment with timestamp at the top of generated java sources, causing the target artifact to have an ever-changing fp which becomes un-cacheable. Any targets dependent on an antlr target will also be uncacheable due to ever-changing dependent hashes, causing build slowdown. Proposed fix is either

  1. scrub the generated sources to remove timestamps
  2. change fingerprint strategy for java_antlr_library so that it hashes the original .g source rather than the generated
@jsirois
Copy link
Contributor

jsirois commented Jun 11, 2015

2 already happens for the inputs to AntlrGen, its outputs though are the inputs to the JavaCompile task and so that's where the fingerprinting instability comes in. So the fix will have to be #1 in the short to medium term.

@qma
Copy link
Contributor Author

qma commented Jun 16, 2015

Implemented #1 in #1701

@stuhood
Copy link
Member

stuhood commented Feb 12, 2016

Fixed.

@stuhood stuhood closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants