Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using executable_search_path in go backend #21346

Open
henri14 opened this issue Aug 22, 2024 · 0 comments
Open

Consider using executable_search_path in go backend #21346

henri14 opened this issue Aug 22, 2024 · 0 comments
Labels
backend: Go Go backend-related issues enhancement

Comments

@henri14
Copy link
Contributor

henri14 commented Aug 22, 2024

The Problem
Whilst working on #21292 I noticed that the go backend uses separate options for search paths. These are _go_search_paths and _cgo_tool_search_paths. I needed an additional search path for the extra-tools option but ended up implicitly using the _go_search_paths.
A number of other backends seem to use executable_search_path option. These are Docker, NodeJS, Pex and Shell.

The Proposal
Enhance the go backend to use executable_search_path for the go binaries, cgo tools and extra tools. This would be done by using the ExecutableSearchPathsOptionMixin.
This would improve consistency in the options for the various backends. It does however impact existing configs that would need to be migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues enhancement
Projects
None yet
Development

No branches or pull requests

2 participants