Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excise direct Pex imports #21401

Closed
cburroughs opened this issue Sep 12, 2024 · 0 comments · Fixed by #21515
Closed

excise direct Pex imports #21401

cburroughs opened this issue Sep 12, 2024 · 0 comments · Fixed by #21515
Labels

Comments

@cburroughs
Copy link
Contributor

In at least two places we directly import from Pex:

src/python/pants/core/subsystems/python_bootstrap.py:from pex.variables import Variables
tests/python/pants_test/init/test_plugin_resolver.py:from pex.interpreter import PythonInterpreter

And it is a dependency in ./3rdparty/python/user_reqs.lock

However, the intended stable interface of Pex is the cli instead of using it 'as a library'. Having two different versions of Pex floating around is also a continuing source of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant