Short option for log level should be shown without equals sign in help output

[bdabelow]

Describe the bug
Currently pants help global shows the usage of the -l short options with an equals sign:

According to this comment in #21426, short options are supposed to be used without equals sign: -ldebug instead of -l=debug. This should be reflected in the help output.

I could not find any other short option beside -l, but possibly others might also be affected.

Pants version
2.24.0.dev0

OS
Linux

[huonw]

Thanks for flagging!

It looks like this logic is controlled by the code below. Some parts of that have logic checking is_short_arg, but this one doesn't and should.

pants/src/python/pants/help/help_info_extracter.py

Lines 1061 to 1062 in 06d4884

	metavar = self.compute_metavar(kwargs)
	display_args.append(f"{scoped_arg}={metavar}")

Are you interested and able in sending a patch that slots in something like separator = "" if is_short_arg else "=" to that part of the code?

[huonw]

(I note that this affects the online docs too: https://www.pantsbuild.org/2.22/reference/global-options#level . I believe the fix to that code should fix those too, as the CLI and HTML docs are generated from the same code.)