Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent result for dependencies #3428

Closed
wisechengyi opened this issue May 13, 2016 · 4 comments
Closed

inconsistent result for dependencies #3428

wisechengyi opened this issue May 13, 2016 · 4 comments

Comments

@wisechengyi
Copy link
Contributor

wisechengyi commented May 13, 2016

the results for two dependencies runs are different:

full log as below, and diff can be found at https://www.diffchecker.com/9ejl4thj, essesntially some shadow targets (not sure if it's the right term) get numbered differently.

./pants --config-override=pants.daemon.ini clean-all
20:28:47 00:00 [main]
               See a report at: http://localhost:52603/run/pants_run_2016_05_12_20_28_47_356_46beddabcfb24ecb93c6c5932cf165a6
20:28:47 00:00   [pantsd]
20:28:47 00:00   [setup]
20:28:47 00:00     [parse]
               Executing tasks in goals: clean-all
20:28:47 00:00   [clean-all]
20:28:47 00:00     [ng-killall]
20:28:47 00:00     [clean-all]
20:28:47 00:00     [kill-pantsd]
20:28:47 00:00   [complete]
               SUCCESS

 ./pants --config-override=pants.daemon.ini dependencies testprojects/maven_layout/provided_patching/:: | sort

3rdparty:junit
junit:junit:4.12
testprojects/maven_layout/provided_patching/leaf:fail
testprojects/maven_layout/provided_patching/leaf:one
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/leaf:test
testprojects/maven_layout/provided_patching/leaf:three
testprojects/maven_layout/provided_patching/leaf:two
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/two/src/main/java:common
testprojects/maven_layout/provided_patching/two/src/main/java:common
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-1


 ./pants --config-override=pants.daemon.ini dependencies testprojects/maven_layout/provided_patching/:: | sort

3rdparty:junit
junit:junit:4.12
testprojects/maven_layout/provided_patching/leaf:fail
testprojects/maven_layout/provided_patching/leaf:one
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-3
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-3
testprojects/maven_layout/provided_patching/leaf:test
testprojects/maven_layout/provided_patching/leaf:three
testprojects/maven_layout/provided_patching/leaf:two
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:common
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/one/src/main/java:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:common
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/three/src/main/java:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/two/src/main/java:common
testprojects/maven_layout/provided_patching/two/src/main/java:common
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-4
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-4
testprojects/maven_layout/provided_patching/two/src/main/java:shadow-unstable-intransitive-4
@kwlzn
Copy link
Member

kwlzn commented May 13, 2016

to be clear, the first run here post-clean does not use the daemon (but launches it from that run) - so this is simply a matter of a difference in the scheduler-backed LegacyBuildGraph and BuildGraph at runtime. i.e. if you were to re-run this a third time I'd expect runs #2 and #3 to be identical.

@wisechengyi
Copy link
Contributor Author

wisechengyi commented May 17, 2016

correct, 2nd and 3rd run are identical, but should the 1st and 2nd run be identical as well? ideally the result of list or dependencies should not vary across runs right?

for example, why does the same target name gets incremented like the following?

testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-1
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-2
testprojects/maven_layout/provided_patching/leaf:shadow-unstable-intransitive-3

@stuhood
Copy link
Member

stuhood commented May 23, 2016

The numbering is based on execution order; it must be stable within a particular implementation of build graph parsing, but I wouldn't expect it to be the same between the two different backends.

So this is probably not an issue, unless @gmalmquist sees an issue.

@stuhood
Copy link
Member

stuhood commented Apr 10, 2017

These are now stabilized using a hash, so #4416 is a brand new and different issue. Resolving.

@stuhood stuhood closed this as completed Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants