Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When failing to find targets in an ignored directory, the error message should reflect the ignorance #3728

Closed
baroquebobcat opened this issue Jul 25, 2016 · 2 comments

Comments

@baroquebobcat
Copy link
Contributor

This can be confusing to people. Especially if they use options that change the ignored paths.

For example, this command fails this way:

$ ./pants --pants-distdir=my-cool-project bundle my-cool-project/app:bin

Exception caught: (<class 'pants.build_graph.build_file_address_mapper.InvalidBuildFileReference'>)
Exception message: /<build-root-path>/my-cool-project/app does not contain any BUILD files.
  when translating spec my-cool-project/app:bin

If it instead said something like

$ ./pants --pants-distdir=my-cool-project bundle my-cool-project/app:bin

Failed to find BUILD files in `my-cool-project/app`. `my-cool-project` is ignored in /<build-root-path>.
  when translating spec my-cool-project/app:bin
@stuhood
Copy link
Member

stuhood commented Jul 25, 2016

This is addressed in the new engine; would recommend tackling #3695 instead.

@baroquebobcat
Copy link
Contributor Author

True. I meant to add that to the description. I filed this as a reminder to test for this scenario, since it's user facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants