Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting pantsbuild.pants dist into pure python and native portions. #5940

Closed
jsirois opened this issue Jun 8, 2018 · 2 comments
Closed

Comments

@jsirois
Copy link
Contributor

jsirois commented Jun 8, 2018

Right now the OSX and linux pantsbuild.pants wheels combine for 20803025 bytes in a multiplatform pex.
If we broke out a very narrow wheel to own just the native engine subsystem / native_engine.so resource file, we'd have 3 wheels combining for 20380596 bytes. This would be a very modest ~500KB (~2%) size savings, so it may not be worth it.

@cosmicexplorer
Copy link
Contributor

This would be way in the future, but #5815 involves stuffing a .so into a python_dist(), and some of the code there could be used in eventually building native_engine.so in pants and packaging the result (which we're obviously nowhere near right now). Vaguely related to the subject of this issue.

@Eric-Arellano
Copy link
Contributor

I believe this proposal has become stale, and instead we'd rather put energy into #7369.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants