Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeCompile strict_deps are too strict #6485

Closed
stuhood opened this issue Sep 11, 2018 · 1 comment
Closed

NativeCompile strict_deps are too strict #6485

stuhood opened this issue Sep 11, 2018 · 1 comment
Labels
bug

Comments

@stuhood
Copy link
Member

stuhood commented Sep 11, 2018

When a python_dist target depends on a ctypes_compatible_cpp_library, NativeCompile currently computes strict_deps in the context of the python_dist library, which means that none of the dependencies of the ctypes_compatible_cpp_library are included (despite the fact that the *_cpp_library is the one that actually owns the relevant sources).
@stuhood
Copy link
Member Author

stuhood commented Sep 11, 2018

...Um, whoops. This isn't true at all.

@stuhood stuhood closed this as completed Sep 11, 2018
@stuhood stuhood mentioned this issue Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuhood