Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper trail swallows warden errors #229

Closed
richmolj opened this issue May 21, 2013 · 1 comment
Closed

Paper trail swallows warden errors #229

richmolj opened this issue May 21, 2013 · 1 comment

Comments

@richmolj
Copy link

Same as #228, which I believe was incorrectly closed.

My issue is not that I want extra logging. My issue is that paper trail, only by being included in the Gemfile, breaks apps. It breaks them by silently swallowing any errors coming from Warden strategies. This means your users get randomly logged out with no reason why, and your app doesn't alert you to the error as it usually would.

If you insist on breaking my app, at the very least add logging telling me you're doing so. But a better fix is to avoid breaking things altogether by avoiding this global rescue, or otherwise altering the implementation.

@batter
Copy link
Collaborator

batter commented May 21, 2013

Please don't open the same exact issue, please re-comment on #228 and we can discuss on that issue. What I'm saying is that you can overwrite that method in your ApplicationController, as is suggested in the README.

@batter batter closed this as completed May 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants