Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install importlib_metadata in the virtualenv #32

Closed
Fenkiou opened this issue Mar 30, 2021 · 3 comments
Closed

Install importlib_metadata in the virtualenv #32

Fenkiou opened this issue Mar 30, 2021 · 3 comments

Comments

@Fenkiou
Copy link

Fenkiou commented Mar 30, 2021

Hello,

I'm currently experiencing a small issue (not a blocking one at all).

I started to use coc, with coc-jedi using a python version >=3.8 and that worked perfectly.

But recently, I launched vim inside a project which uses python 3.6.6. And update coc plugins.

Seems like coc-jedi needed an update (and jedi-language-server too was outdated). So coc-jedi ran the update but it ran it using the python 3.6.6 interpreter.

So the virtualenv created is based on python 3.6.6 and now each time coc-jedi starts to run, it tries to get the version, but it cannot retrieve it because if we're below 3.8, we have to use importlib_metadata (see here) which is not installed. So it recreate the virtualenv each time.

I can fix the issue either by:

  • reinstalling coc-jedi using a python version > 3.8
  • install importlib_metadata inside actual coc-jedi virtualenv (which will break once new update is installed if I'm using python <3.8 interpreter)

Can we add importlib_metadata package installation inside the virtualenv? Or maybe there is another solution :)

Anyway, thanks for the plugin!

@pappasam
Copy link
Owner

Thanks for this issue! I'll add a conditional dependency for importlib_metadata to jedi-language-server and release later today

@pappasam
Copy link
Owner

Should be resolved in version 0.25.2!

@Fenkiou
Copy link
Author

Fenkiou commented Mar 31, 2021

Works perfectly, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants