Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workspace/didChangeConfiguration notification #58

Closed
karthiknadig opened this issue Feb 3, 2021 · 3 comments
Closed

Comments

@karthiknadig
Copy link
Contributor

Add support for this notification: https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_didChangeConfiguration

Currently I get this error when it is sent.

Failed to handle notification workspace/didChangeConfiguration
Traceback (most recent call last):
  File "c:\GIT\s p\vscode-python\pythonFiles\lib\python\pygls\protocol.py", line 279, in _get_handler
    return self.fm.builtin_features[feature_name]
KeyError: 'workspace/didChangeConfiguration'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\GIT\s p\vscode-python\pythonFiles\lib\python\pygls\protocol.py", line 282, in _get_handler
    return self.fm.features[feature_name]
KeyError: 'workspace/didChangeConfiguration'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\GIT\s p\vscode-python\pythonFiles\lib\python\pygls\protocol.py", line 306, in _handle_notification
    handler = self._get_handler(method_name)
  File "c:\GIT\s p\vscode-python\pythonFiles\lib\python\pygls\protocol.py", line 284, in _get_handler
    raise JsonRpcMethodNotFound.of(feature_name)
pygls.exceptions.JsonRpcMethodNotFound
@krassowski
Copy link
Contributor

krassowski commented Feb 3, 2021

Seconded, this also affects jupyterlab integration

@pappasam
Copy link
Owner

pappasam commented Feb 3, 2021

@krassowski @karthiknadig Please try out this PR and let me know if it resolves the issue for you. We can figure out how / whether to support configuration updates for a running server later, that might take a lot more time than suppressing this error.

#59

@karthiknadig
Copy link
Contributor Author

@pappasam that worked for me. Thanks.

@pappasam pappasam closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants