Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution witness recorder type #12532

Closed
mattsse opened this issue Nov 14, 2024 · 0 comments · Fixed by #12566
Closed

Add execution witness recorder type #12532

mattsse opened this issue Nov 14, 2024 · 0 comments · Fixed by #12566
Assignees
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 14, 2024

Describe the feature

we need execution witness in multiple place 12238 and

codes = statedb

we can make this reusable by introducing a container type for

let mut hashed_state = HashedPostState::default();
let mut keys = HashMap::default();
let mut codes = HashMap::default();

and convert the logic of this closure

|statedb: &State<_>| {

into a function of ExecutionWitnessRecorder

this type should be introduced here:

name = "reth-revm"

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 14, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-execution Related to the Execution and EVM and removed S-needs-triage This issue needs to be labelled labels Nov 14, 2024
@mattsse mattsse self-assigned this Nov 15, 2024
@mattsse mattsse removed the D-good-first-issue Nice and easy! A great choice to get started label Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant