enforce --no-default-features via cargo hack

[mattsse]

Describe the feature

this will resurface again and again #9478

we should enforce this via cargo hack

reth/.github/workflows/lint.yml

Line 73 in da0efbe

- run: cargo hack check

TODO

• add cargo hack step that does check --no-default-features

Additional context

No response

[diegoTech14]

Hello @mattsse,

I'm Diego Duarte from Costa Rica and I would like to help with this issue. I am a Web3 learner and I would like to learn about Rust.

Here is my OD profile.

---

Best regards,
Diego Duarte

Thanks for your consideration!

[rohankumar17]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a second-year Software Engineering student with experience in programming languages such as Python, C, and C++. I have completed internships where I applied my skills in these languages. Recently, I have begun learning Rust and have engaged in practical exercises to enhance my proficiency. I am now seeking real-world issues and projects to work on that will motivate me to further develop my Rust skills and put my knowledge into practice.

How I plan on tackling this issue

To make sure the project builds successfully without relying on default features, I would tweak the CI workflow. I would begin updating the no-test-deps job to use the command cargo hack check --no-default-features. This command tells cargo hack to build the project while excluding any default features defined in the Cargo.toml. Additionally, I would update the lint-success job to include no-test-deps in its dependency list. This way, the overall CI will fail if the build without the default features doesn't pass. By making these changes, I can enforce stricter build requirements within the CI pipeline.

[github-actions]

This issue is stale because it has been open for 21 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.