Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Compatibility #2750

Open
Manikanta-20 opened this issue May 20, 2020 · 7 comments
Open

Password Compatibility #2750

Manikanta-20 opened this issue May 20, 2020 · 7 comments
Assignees
@owenl131
Labels
difficulty:medium Feature Request hacktoberfest

Comments

@Manikanta-20
Copy link

Feature Request
Add Password feature to pdf?
@HackbrettXXX
Copy link
Collaborator

Would definitively be good. We are happy about pull requests :)

@marcohamersma marcohamersma mentioned this issue Jun 11, 2020
Closed
@HackbrettXXX
Copy link
Collaborator

One could check out/start with the changesets in #1746.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.

@owenl131
Copy link
Contributor

Hi, I would like to work on this.

@HackbrettXXX
Copy link
Collaborator

Alright, thanks! I'm assigning you.

@owenl131
Copy link
Contributor

How shall we write automated testing for this?

@owenl131 owenl131 mentioned this issue Oct 14, 2020
Merged
@HackbrettXXX
Copy link
Collaborator

Either by creating entire encrypted reference PDFs and comparing with them or testing the output of only some methods, like e.g. here. If you haven't read it yet, here is the guide for testing: https://github.com/MrRio/jsPDF/blob/master/CONTRIBUTING.md#building-and-testing-jspdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenl131 owenl131

Labels
difficulty:medium Feature Request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owenl131 @HackbrettXXX @Manikanta-20