Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CVE-2020-7691 ( very similar to CVE-2020-7690 ) #2971

Closed
SirJalias opened this issue Oct 20, 2020 · 4 comments
Closed

Address CVE-2020-7691 ( very similar to CVE-2020-7690 ) #2971

SirJalias opened this issue Oct 20, 2020 · 4 comments

Comments

@SirJalias
Copy link

Hello!

This vulnerability is very similar to #2795 so I think it should be already fixed.

The fact is that gemnasium that is dependency scanner is warning about this issue:

+------------+----------------------------------------------------------------------------------+
| Severity | Medium |
| Identifier | CVE-2020-7691 |
| URL | https://nvd.nist.gov/vuln/detail/CVE-2020-7691 |
| Scanner | gemnasium |
| Message | Cross-site Scripting in jspdf |
| Package | jspdf 2.1.1 |
| Solution | Unfortunately, there is no solution available yet. |
| Path | |
| File | yarn.lock |
+------------+----------------------------------------------------------------------------------+

And it is very similar to the one that was solved in the mentioned issue, so I don't know if there is something needed to do.
I did a test and it is working well here

If you could do a quick check I will appreciate it.

Thank you!

@HackbrettXXX
Copy link
Collaborator

I think this should in fact be fixed already. If not, it's an issue of Dompurify, the library we use to sanitize HTML strings.

@aruniverse
Copy link
Contributor

i believe you just need to update the optional dependency on dompurify to ^2.1.0 and update the lock file. if that sounds good i can make a pr for this

@anatolie-darii
Copy link

@HackbrettXXX I see this issue is closed but https://nvd.nist.gov/vuln/detail/CVE-2020-7691 still says that all pdfjs versions are affected(which includes latest one as well) as opposed to https://nvd.nist.gov/vuln/detail/CVE-2020-7690 which mentions correctly that only versions < 2.0.0 are affected.

@HackbrettXXX
Copy link
Collaborator

Thanks, I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants