Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate protobuf from API #3

Open
samspycher opened this issue Oct 5, 2021 · 0 comments
Open

Separate protobuf from API #3

samspycher opened this issue Oct 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@samspycher
Copy link
Collaborator

samspycher commented Oct 5, 2021 •
edited
Loading

The package parsec-interface-java currently contains the API for interacting with the wire protocol, and exposes references to protobuf classes.

Any direct references to protobuf classes should be separately packaged and hidden from external access.

Solution proposal

parsec-interface-java is built on the model of parsec-interface-rs and also named after it. This naming is somewhat confusing, since this is not an external interface, but the interface to the wire protocol.

We may introduce a parsec-api-java package to contain the actual API, and move all true external interface and parameter classes there. protobuf class interaction remains in parsec-interface-java.
@grealish grealish added the enhancement New feature or request label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samspycher @grealish