Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tsc typechecking to pre-commit to catch Typescript errors #1085

Open
tombogle opened this issue Aug 22, 2024 · 1 comment · May be fixed by #1088
Open

Add tsc typechecking to pre-commit to catch Typescript errors #1085

tombogle opened this issue Aug 22, 2024 · 1 comment · May be fixed by #1088
Assignees
@irahopkinson

Comments

@tombogle
Copy link
Contributor

tombogle commented Aug 22, 2024 •
edited
Loading

Needs to be configured to only do TS compilation on the parts of the monorepo that actually have our code, probably somewhat similar to the way eslint is configured.
@irahopkinson irahopkinson changed the title Add tsc to pre-commit to catch Typescript errors Add tsc typechecking to pre-commit to catch Typescript errors Aug 22, 2024
@irahopkinson
Copy link
Contributor

Once typechecking is set up we can set 'consistent-return': 'off', in all eslint configs (.eslintrc.js) since https://typescript-eslint.io/rules/consistent-return/ recommends using tsconfig's noImplicitReturns option which is already on (except in platform-bible-react and platform-bible-utils).

@irahopkinson irahopkinson mentioned this issue Aug 22, 2024
Merged
@irahopkinson irahopkinson self-assigned this Aug 25, 2024
irahopkinson added a commit that referenced this issue Aug 25, 2024
@irahopkinson
add type checking
914f3a1 
- fixes #1085
- include core, extensions, platform-bible-utils, platform-bible-react
- fix existing type checking errors
- add typecheck to pre-commit
@irahopkinson irahopkinson linked a pull request Aug 25, 2024 that will close this issue
Open
irahopkinson added a commit that referenced this issue Aug 27, 2024
@irahopkinson
add type checking
0703809 
- fixes #1085
- include core, extensions, platform-bible-utils, platform-bible-react
- fix existing type checking errors
- add typecheck to pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irahopkinson irahopkinson

Labels
None yet
Projects
Paranext
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add type checking paranext/paranext-core
2 participants
@tombogle @irahopkinson