Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Change discriminant from _tag to type #93

Closed
tjjfvi opened this issue Jun 11, 2022 · 1 comment · Fixed by #100
Closed

Change discriminant from _tag to type #93

tjjfvi opened this issue Jun 11, 2022 · 1 comment · Fixed by #100
Assignees
@tjjfvi

Comments

@tjjfvi
Copy link
Contributor

tjjfvi commented Jun 11, 2022

type isn't a valid Rust identifier (unless escaped via r#type), so this minimizes chance of collision.
@tjjfvi tjjfvi self-assigned this Jun 12, 2022
@harrysolovay
Copy link
Contributor

Let's make sure to update the examples in _docs/Types.md as well

@tjjfvi tjjfvi mentioned this issue Jun 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tjjfvi tjjfvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename type to ty and _tag to type & remove enums paritytech/capi
2 participants
@harrysolovay @tjjfvi