feat: use CARGO_ENCODED_RUSTFLAGS
instead of RUSTFLAGS
#1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
CARGO_ENCODED_RUSTFLAGS
instead ofRUSTFLAGS
incontract-build
crate. This does not affect/break anything.Why?
I wanted to use
contract-build
inside cargo build script for compiling ink! contract fixtures for testing, here is a example build script - https://github.com/AstarNetwork/Astar/blob/e148ddf271577b4e36662afe4b9ec820c235a384/tests/xcm-simulator/build.rs. But with the current use ofRUSTFLAGS
it's not possible.Since with Rust 1.55.0,
RUSTFLAGS
is not set for build scripts - rust-lang/cargo#10111. On top of that when cross-compiling (in our casewasm32-unknown-unknown
), cargo does not applyRUSTFLAGS
for build scripts by design. That meansRUSTFLAGS
will totally be ignored in build script environment, that includes setting env from inside build script.Solution
Simply use
CARGO_ENCODED_RUSTFLAGS
instead - rust-lang/cargo#10111 (comment)