Configurable max memory pages #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
kvinwang
force-pushed
the
max-memory-pages
branch
from
2438e4b
to
7b8a928
Compare
kvinwang
force-pushed
the
max-memory-pages
branch
from
7b8a928
to
ff72a5a
Compare
ascjones
reviewed
May 25, 2023
kvinwang
force-pushed
the
max-memory-pages
branch
from
ff72a5a
to
3df6e5f
Compare
ascjones
approved these changes
May 25, 2023
Merged
kvinwang
added a commit
to kvinwang/cargo-contract
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds and command line argument
--max-memory-pagestocargo contract build.Background
Contracts on Phala Networks are allowed to use up to 4MB of memory.
cargo-contractdid enforce the wasm to set max pages to 16. That would cause a build error when our contracts use larger memory: