Fix for a Url to String conversion in info command #1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes none
ink
orpallet-contracts
?Fix for Url to String conversion
Description
According to url crate specification: "default port numbers are never reflected by the serialization"
Implemented function converts a Url into a string representation without excluding the default port.
For now the change is only for info command, but as follow up task is required a change in contract-extrinsics.
Conversion used there does not support correctly urls like: wss://shiden.api.onfinality.io:443/public-ws
The best option would be to have one common public function
Checklist before requesting a review
CHANGELOG.md