Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a Url to String conversion in info command #1330

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Sep 12, 2023

Summary

Closes none

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Fix for Url to String conversion

Description

According to url crate specification: "default port numbers are never reflected by the serialization"
Implemented function converts a Url into a string representation without excluding the default port.

For now the change is only for info command, but as follow up task is required a change in contract-extrinsics.
Conversion used there does not support correctly urls like: wss://shiden.api.onfinality.io:443/public-ws
The best option would be to have one common public function

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@ascjones ascjones merged commit 004e44e into master Sep 14, 2023
10 checks passed
@ascjones ascjones deleted the sm/fix-url branch September 14, 2023 12:09
@smiasojed smiasojed mentioned this pull request Nov 30, 2023
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants