Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests in the contract template #1537

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix e2e tests in the contract template #1537

merged 2 commits into from
Mar 13, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Mar 12, 2024 •
edited
Loading

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Fix e2e tests in the contract template

Description

ink e2e tests were not updated to version 5, causing failures when executing the following commands

cargo contract new hehe
cargo test --release --features e2e-tests

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

cmichi
cmichi approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing such a fast fix!

Can you add a CHANGELOG.md entry?

We should then subsequently publish a cargo-contract 4.0.1 patch release.

@smiasojed smiasojed requested a review from a team as a code owner March 12, 2024 20:04
ascjones
ascjones approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow these e2e tests were really out of date!

@smiasojed smiasojed merged commit 6f4c6dd into master Mar 13, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/fix-new branch March 13, 2024 11:44
@smiasojed smiasojed mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@ascjones ascjones ascjones approved these changes

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smiasojed @ascjones @cmichi