-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preferred default release profile settings #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all LGTM, some renamings wouldn't hurt though.
Also really nice feature!
src/workspace.rs
Outdated
/// False = no LTO | ||
/// True = "Fat" LTO | ||
Bool(bool), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be much worse to have FatLto
, ThinLto
and Off
as variants? Kind of dislike the Bool
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See what you think of the explicit variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rel #40, use-ink/ink#448
If any of the following
[profile.release]
settings are missing, then they are added with the following preferred defaults:Any of the above that are manually specified are not overwritten. This allows manual control over e.g.
opt-level
where in some casesopt-level = 3
might result in a smaller binary size.Template changes:
[profile.release]
sectionUse(reverted: requires ink! 3 release)scale-info
from crates.io instead oftype-metadata