Implement ecdsa_to_eth_address() and remove eth_compatibility crate
#1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agryaznov
requested review from
Robbepop,
cmichi,
ascjones and
HCastano
as code owners
|
The function shouldn't be removed. It should be replaced with a call to the new seal function. |
|
I was just thinking on removal the whole |
agryaznov
changed the title
ink_eth_compatibility::to_eth_address() and libsecp256k1 depeth_compatibility crate and implement ecdsa_to_eth_address()
athei
approved these changes
May 2, 2022
cmichi
reviewed
May 2, 2022
cmichi
reviewed
May 2, 2022
cmichi
reviewed
May 2, 2022
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Thu May 12 14:19:45 CEST 2022 |
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
===========================================
+ Coverage 61.64% 78.74% +17.09%
===========================================
Files 228 228
Lines 8654 8675 +21
===========================================
+ Hits 5335 6831 +1496
+ Misses 3319 1844 -1475
Continue to review full report at Codecov.
|
Co-authored-by: Michael Müller <[email protected]>
agryaznov
changed the title
eth_compatibility crate and implement ecdsa_to_eth_address()ecdsa_to_eth_address() and ecdsa_to_default_account_id(), remove eth_compatibility crate
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
cmichi
reviewed
May 12, 2022
Co-authored-by: Michael Müller <[email protected]>
…ility crate" This reverts commit 70a9189.
|
After further discussion it was finally decided to remove |
agryaznov
changed the title
ecdsa_to_eth_address() and ecdsa_to_default_account_id(), remove eth_compatibility crateecdsa_to_eth_address() and remove eth_compatibility crate
cmichi
approved these changes
May 13, 2022
agryaznov
added a commit
that referenced
this pull request
Jun 6, 2022
agryaznov
added a commit
that referenced
this pull request
Jun 22, 2022
* Fix links in release notes (#1277) * Revert "Optimise deny_payment. Use eerywhere semantic of deny. (#1267)" This reverts commit 1bfccc7. * Revert backward-incompatible piece of #1224: dependency on `[seal1] seal_set_storage` * Revert backward-incompatible piece of #1233: removal of eth_compatibility crate * bump crate versions + update RELEASES.md * Mapping::insert_return_size is back, having now both `seal1` and `seal0` seal_set_storage versions used * set_storage_silent -> set_storage_compat renaming * spell fix * Apply suggestions from code review Co-authored-by: Michael Müller <[email protected]> Co-authored-by: Hernando Castano <[email protected]> * Apply suggestions from code review Co-authored-by: Hernando Castano <[email protected]> * Update crates/env/src/backend.rs Co-authored-by: Hernando Castano <[email protected]> * doc comments enhanced * `Mapping::insert()` to use backwards compatible seal fn * unreleased changes planned for 4.x removed from 3.x * Add more details to the release notes * fix catched issue with changed api function signature * fix storage trait dependent func * Apply new versions naming policy: step1. Old versions to keep their names. * Apply new versions naming policy: step2. Add `deprecated` attr and `# Compatibility` docs section * Apply suggestions from code review Co-authored-by: Hernando Castano <[email protected]> * fixes after next review round * more fixes after the review round * fmt * spellcheck config fix * Small wording fixes Co-authored-by: Michael Müller <[email protected]> Co-authored-by: Hernando Castano <[email protected]> Co-authored-by: Hernando Castano <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsecp256k1dependency ofink_eth_compatibility#1068Ported the following function from
eth_compatibilitycrate toink_env:eth_compatibilitycrate removed as having no reason to exist anymore