-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mapping::take()
#1461
Add Mapping::take()
#1461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things, but generally looks good.
Also, do you know what the version of the contracts pallet introduced seal_take
? We'll need to know so we can mention it in the release notes (oh btw, can you add an entry to the CHANGELOG
for this)
|
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
+ Coverage 45.77% 46.97% +1.19%
==========================================
Files 201 201
Lines 6187 6210 +23
==========================================
+ Hits 2832 2917 +85
+ Misses 3355 3293 -62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits with the wrapping, but otherwise looks good
Co-authored-by: Hernando Castano <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>
This PR adds a new function
Mapping::take()
which retrieves and removed a value under the given key from the storage.