Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scale-info requirement to 2.3 #1467

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Nov 4, 2022

Follow up to #1357 which uses some 2.3 features so now this is the minimum required version.

@ascjones ascjones changed the title Update scale-info requirement to 2.3 Update scale-info requirement to 2.3 Nov 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1467 (1d6fbaf) into master (eeb00ed) will increase coverage by 25.22%.
The diff coverage is 0.00%.

❗ Current head 1d6fbaf differs from pull request most recent head 5d3df35. Consider uploading reports for the commit 5d3df35 to get more accurate results

@@             Coverage Diff             @@
##           master    #1467       +/-   ##
===========================================
+ Coverage   45.82%   71.04%   +25.22%     
===========================================
  Files         201      201               
  Lines        6187     6189        +2     
===========================================
+ Hits         2835     4397     +1562     
+ Misses       3352     1792     -1560     
Impacted Files Coverage Δ
crates/e2e/src/utils.rs 0.00% <0.00%> (ø)
crates/storage/src/lazy/mapping.rs 71.42% <ø> (ø)
crates/allocator/src/bump.rs 85.12% <0.00%> (-2.28%) ⬇️
crates/metadata/src/layout/mod.rs 76.42% <0.00%> (-1.63%) ⬇️
crates/ink/ir/src/ir/attrs.rs 82.27% <0.00%> (+3.87%) ⬆️
crates/ink/ir/src/ir/trait_def/item/mod.rs 88.52% <0.00%> (+4.91%) ⬆️
crates/env/src/engine/off_chain/test_api.rs 64.70% <0.00%> (+5.88%) ⬆️
crates/ink/ir/src/ir/item_impl/constructor.rs 91.80% <0.00%> (+8.19%) ⬆️
crates/engine/src/ext.rs 66.27% <0.00%> (+8.28%) ⬆️
crates/ink/ir/src/ir/idents_lint.rs 71.42% <0.00%> (+9.52%) ⬆️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascjones ascjones merged commit f2e799e into master Nov 4, 2022
@ascjones ascjones deleted the aj/upgrade-scale-info-requirement branch November 4, 2022 13:14
@ascjones ascjones mentioned this pull request Nov 22, 2022
1 task
@ascjones ascjones mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants