Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RefundRelayerForMessagesFromParachain readability #1838

Closed
svyatonik opened this issue Feb 1, 2023 · 0 comments · Fixed by #1895
Closed

Improve RefundRelayerForMessagesFromParachain readability #1838

svyatonik opened this issue Feb 1, 2023 · 0 comments · Fixed by #1895
Assignees
@serban300
Labels
A-docs Improvements or additions to documentation
Milestone
When Thou Have Sp...

Comments

@svyatonik
Copy link
Contributor

It is hard to understand what all those generic arguments (see

parity-bridges-common/bin/runtime-common/src/refund_relayer_extension.rs

Line 104 in 3363231

pub struct RefundRelayerForMessagesFromParachain<RT, GI, PI, MI, BE, PID, LID, FEE>(
) mean - we need document every parameter, or make them self-descriptive.
@svyatonik svyatonik added the A-docs Improvements or additions to documentation label Feb 1, 2023
@svyatonik svyatonik added this to the When Thou Have Spare Hour milestone Feb 1, 2023
@serban300 serban300 self-assigned this Feb 8, 2023
This was referenced Feb 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
A-docs Improvements or additions to documentation
Projects
None yet
Milestone
When Thou Have Spare Hour
Development

Successfully merging a pull request may close this issue.

RefundRelayerForMessagesFromParachain improvements serban300/parity-bridges-common
2 participants
@svyatonik @serban300