You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to the retiring of puppet workers, the PVF tests now depend not on fake workers but on the actual real workers. This is better as we now test the real thing, on the other hand we now have to remember to manually rebuild the actual workers before running tests. There are two issues with this:
After Make the node version independent of the crate version #1495 the workers now depend on polkadot-cli (for NODE_VERSION), which itself transitively depends on the PVF system. This means that if you make a change in PVF and need to test it, all of polkadot-cli gets rebuilt when you build the workers.
Couple of ideas:
Maybe the build script of PVF can make sure the workers were built with the current git commit hash?
Move NODE_VERSION into some shared location. Maybe something like a .env file or some equivalent that works with cargo, so an env var gets set which we can use at compile-time.
After some testing, it seems that even if the workers pull in nothing from pvf, they always depend on it. Cargo considers them to have this dependency regardless, because they are bin targets in the same crate as polkadot and share dependencies with it. To fix it, they need to be in their own crate instead of sharing a crate with polkadot.
Due to the retiring of puppet workers, the PVF tests now depend not on fake workers but on the actual real workers. This is better as we now test the real thing, on the other hand we now have to remember to manually rebuild the actual workers before running tests. There are two issues with this:
NODE_VERSION
), which itself transitively depends on the PVF system. This means that if you make a change in PVF and need to test it, all of polkadot-cli gets rebuilt when you build the workers.Couple of ideas:
MoveNODE_VERSION
into some shared location. Maybe something like a.env
file or some equivalent that works with cargo, so an env var gets set which we can use at compile-time.pvf
, they always depend on it. Cargo considers them to have this dependency regardless, because they arebin
targets in the same crate aspolkadot
and share dependencies with it. To fix it, they need to be in their own crate instead of sharing a crate withpolkadot
.cc @s0me0ne-unkn0wn
The text was updated successfully, but these errors were encountered: