Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review-Bot is failing. Can not obtain action secrets #1754

Closed
Bullrich opened this issue Sep 29, 2023 · 4 comments · Fixed by #1748
Closed

Review-Bot is failing. Can not obtain action secrets #1754

Bullrich opened this issue Sep 29, 2023 · 4 comments · Fixed by #1748
Assignees
Labels
I2-bug The node fails to follow expected behavior.

Comments

@Bullrich
Copy link
Contributor

Review bot seems to be having an issue to obtain the repository secrets.

It has an environment set up for the secrets.

Related documentation: https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

@Bullrich Bullrich added the I2-bug The node fails to follow expected behavior. label Sep 29, 2023
@Bullrich Bullrich self-assigned this Sep 29, 2023
@Bullrich
Copy link
Contributor Author

@altaua I created this ticket so we can centralize our progress.

I'll be experimenting on a staging repository to find the correct way to access variables.

@Bullrich
Copy link
Contributor Author

I believe I found the issue.

It seems that pull_request_target counts as running an action outside of the branch, hence it doesn't allow it to access the environment secret.

I did a simple test and found the same result:
image

This is why in #1748 the pull_request_review event is working but not the pull_request_target.

@pavelsupr I'm afraid we will have to remove the secret from the environment and put it as a repository secret for this to work.

@pavelsupr
Copy link
Contributor

Hey @Bullrich , I saw the issue already yesterday on polkadot-sdk (thanks to Mira who pinged me), and I already moved the secrets on the repo level, it was about 10h ago.

@pgherveou
Copy link
Contributor

Hi we are seeing similar errors on this PR
#1331
The issue is closed but we are still seeing the error, do we need to rebase or do sonething else to make it pass ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants